Tooltip Infinite Loop fix - Shift or Adjust the tooltip to fit in one monitor #557 #2012
Conversation
amartya4256
force-pushed
the
amartya4256/tree_tooltip_deadlock
branch
from
5d27af7 to
295abc9
Compare
Test Results 539 files +13 539 suites +13 31m 17s ⏱️ - 2m 53s For more details on these failures, see this check. Results for commit 2e9d2c4. ± Comparison against base commit e63c07d. ♻️ This comment has been updated with latest results. |
amartya4256
force-pushed
the
amartya4256/tree_tooltip_deadlock
branch
2 times, most recently
from
f163a29 to
4c02530
Compare
amartya4256
changed the title
HeikoKlare
left a comment
HeikoKlare
left a comment
There was a problem hiding this comment.
Awesome! Thank you, @amartya4256!
I tested with several scenarios, in particular the ones reported in #557, and the problem is properly solved by ensuring that tooltips are always placed inside a single monitor instead of spanning multiple monitors. I tested with both the monitor-specific scaling mode as well as the mode, in which the issue occured as well, and both work fine now.
I think is also valid to just truncate tooltips if they would exceed the horizontal size of a monitor, so that decision is fine more me.
The code also look sound to me. I only have rather nitpicky comments.
bundles/org.eclipse.swt/Eclipse SWT/win32/org/eclipse/swt/widgets/Tree.java
Outdated
Show resolved
Hide resolved
bundles/org.eclipse.swt/Eclipse SWT/win32/org/eclipse/swt/widgets/Tree.java
Outdated
Show resolved
Hide resolved
bundles/org.eclipse.swt/Eclipse SWT/win32/org/eclipse/swt/widgets/Tree.java
Show resolved
Hide resolved
bundles/org.eclipse.swt/Eclipse SWT/win32/org/eclipse/swt/widgets/Tree.java
Outdated
Show resolved
Hide resolved
amartya4256
force-pushed
the
amartya4256/tree_tooltip_deadlock
branch
from
4c02530 to
1a55dab
Compare
HeikoKlare
force-pushed
the
amartya4256/tree_tooltip_deadlock
branch
2 times, most recently
from
6bf9700 to
16b37b6
Compare
This commit contributes to fixing the infinite looping effect on painting a tooltip over a TreeItem on win32 when a tooltip spans over two monitors having more area on the other monitor than the one on which the cursor is placed. The fix makes sure that the tooltip is not drawn on the other monitors by shifting or adjusting the width. Fixes eclipse-platform#557
HeikoKlare
force-pushed
the
amartya4256/tree_tooltip_deadlock
branch
from
16b37b6 to
2e9d2c4
Compare
|
Windows test failure is unrelated: #1843 Merging this despite Jenkins failure caused by https://gitlab.eclipse.org/eclipsefdn/helpdesk/-/issues/5892 Since master builds seem to still work on Jenkins, the subsequent master build should hopefully work, thus I will check results of that build to retrospectively validate this PR. |
|
No new issues on subsequent master build for 00c6aef |
2 participants
This PR contributes to fixing the infinite looping effect on showing a tooltip of the tree using per-monitor (V2) awareness on win32 when a tooltip is spans over two monitors having more area on the other monitor than the one on which the cursor is placed. The fix makes sure that the tooltip is not drawn on the other monitors by shifting and adjusting the width.
contributes to #557